Re: [PATCH v3 2/8] help: make autocorrect handling reusable

From: Jiamu Sun <39@barroit.sh>
Date: Mar 11, 2026, 02:05 UTC
Message-ID: <SY0P300MB0801952EB445C6B196EEEFEFCE47A@SY0P300MB0801.AUSP300.PROD.OUTLOOK.COM>
In-Reply-To: <xmqqcy1btpht.fsf@gitster.g>

On Tue, Mar 10, 2026 at 01:10:22PM -0700, Junio C Hamano wrote:

> > Why not use s/autocorr/autocorrect/ ? Also would be nice to add some
> > documentation about each of the functions here.
> 
> Good.

Used autocorr just because it's shorter than autocorrect. Will rename it and add docs in v4.

Show 9 quoted lines

> > Also got this from running `git-clang-format` on this commit. Generally
> > applying changes while moving code makes it harder to review. But here
> > the changes are small enough that we could get away with it. I'll leave
> > it to you.
> 
> No, you cannot leave it to the author.  
> 
> Leave it to CodingGuidelines; case and switch would start at the
> same column.

Was just copy-pasted as-is. Will fix.

-- 
Jiamu Sun <39@barroit.sh>
          <sunjiamu@outlook.com>