Re: [PATCH 2/5] help: refactor command autocorrection handling
- From
- Jiamu Sun <39@barroit.sh>
- Date
- Mar 9, 2026, 02:06 UTC
- Message-ID
- <SY0P300MB080153161083DAA000A77035CE79A@SY0P300MB0801.AUSP300.PROD.OUTLOOK.COM>
- In-Reply-To
- <xmqqsea998vd.fsf@gitster.g>
On Sun, Mar 08, 2026 at 04:52:54PM -0700, Junio C Hamano wrote:
Show 19 quoted lines
> You snuck in unnecessary "style fixes" to make bunch of "if()return" > into if/else if cascade. Also what was AUTOCORRECT_SHOW is now > returned as AUTOCORR_HINTONLY. There is no explanation on the > reason behind these changes in the proposed log message, and hiding > these small changes in a code movement patch makes reviewing the > series harder than necessary. > > The patch is doing too many things (namely, (1) code movement that > will make it later reusable as a side effect but has no semantic > changes in the current code, plus (2) change in style (like the one > we see here), semantics (possibly the difference in SHOW and > HINTONLY we see here) and features, possibly including the renaming > of AUTOCORRECT_* into AUTOCORR_*.) Let's have "restructure with > code movement and nothing else", followed by "other changes > > I'll stop here, and expect this step to be split into at least two > patches to make it more readable before we can review it again. > > Thanks.
Ah, I realized this patch is completely unreadable. You are right, the code movement ended up hiding other changes entirely. Will split it to make each change obvious.
-- Jiamu Sun <39@barroit.sh>