git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/6] builtin-commit: Add newline when showing which commit was created

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 2, 2007, 17:18 UTC
Message-ID
<Pine.LNX.4.64.0712021716220.27959@racer.site>
In-Reply-To
<20071202165409.GA30998@coredump.intra.peff.net>
Hi,
On Sun, 2 Dec 2007, Jeff King wrote:
Show 10 quoted lines
> On Sun, Dec 02, 2007 at 12:13:07PM +0000, Johannes Schindelin wrote:
> 
> > > It would be helpful if you could remember the test case, but perhaps
> > > that is not an option at this point.
> > 
> > IIRC it was "git commit -m bla".
> 
> I have made several attempts to reproduce the problem, looked a bit
> through the log-tree code, and checked the results of the t750* series
> of tests; but I have found nothing.

I remember again. When I did "commit -s -m bla" the empty line between the oneline and the signoff would be missing. But in the meantime, the signoff was dragged into the strbuf and all is well.

ACK.

Ciao, Dscho

Previous: Jeff KingNext: Junio C Hamano
Message 20 of 24 in “Various (replacement) patches to builtin-commit”
  1. 0/6 Various (replacement) patches to builtin-commitJohannes Schindelin, Nov 11, 2007
  2. 1/6 builtin-commit: fix author date with --amend --author=<author>Johannes Schindelin, Nov 11, 2007
  3. Kristian HøgsbergNov 12, 2007
  4. Johannes SchindelinNov 12, 2007
  5. Junio C HamanoNov 13, 2007
  6. 2/6 git status: show relative paths when run in a subdirectoryJohannes Schindelin, Nov 11, 2007
  7. 3/6 builtin-commit: fix --signoffJohannes Schindelin, Nov 11, 2007
  8. 4/6 builtin-commit --s: add a newline if the last line was no S-O-BJohannes Schindelin, Nov 11, 2007
  9. 5/6 builtin-commit: resurrect behavior for multiple -m optionsJohannes Schindelin, Nov 11, 2007
  10. Pierre HabouzitNov 11, 2007
  11. Johannes SchindelinNov 11, 2007
  12. Pierre HabouzitNov 11, 2007
  13. Pierre HabouzitNov 11, 2007
  14. 6/6 builtin-commit: Add newline when showing which commit was createdJohannes Schindelin, Nov 11, 2007
  15. Jeff KingDec 1, 2007
  16. Johannes SchindelinDec 1, 2007
  17. Jeff KingDec 2, 2007
  18. Johannes SchindelinDec 2, 2007
  19. Jeff KingDec 2, 2007
  20. Johannes SchindelinDec 2, 2007
  21. Junio C HamanoDec 2, 2007
  22. Johannes SchindelinDec 2, 2007
  23. Junio C HamanoDec 3, 2007
  24. Jeff KingDec 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.