Re: [PATCH 6/6] builtin-commit: Add newline when showing which commit was created

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 1, 2007, 22:41 UTC
Message-ID: <Pine.LNX.4.64.0712012238510.27959@racer.site>
In-Reply-To: <20071201222106.GA27102@coredump.intra.peff.net>

Hi,

On Sat, 1 Dec 2007, Jeff King wrote:

Show 8 quoted lines

> On Sun, Nov 11, 2007 at 05:36:52PM +0000, Johannes Schindelin wrote:
> 
> > The function log_tree_commit() does not break the line, so we have to
> > do it ourselves.
> 
> Johannes,
> 
> Can you explain the rationale for this change in more detail?

Basically, I ran a test case in which the shell script was different from the builtin version, and this was the patch that fixed it for me.

Maybe it should have been

	if (log_tree_commit(&rev, commit))
		printf("\n");

at the end of print_summary() instead. Can you try if that fixes it for you?

Ciao, Dscho