Re: [PATCH 6/6] builtin-commit: Add newline when showing which commit was created

From: Jeff King <peff@peff.net>
Date: Dec 1, 2007, 22:21 UTC
Message-ID: <20071201222106.GA27102@coredump.intra.peff.net>
In-Reply-To: <Pine.LNX.4.64.0711111736440.4362@racer.site>

On Sun, Nov 11, 2007 at 05:36:52PM +0000, Johannes Schindelin wrote:

> The function log_tree_commit() does not break the line, so we have to
> do it ourselves.

Johannes,

Can you explain the rationale for this change in more detail?

When I run builtin-commit from the tip of next, I always get an extra newline (as compared to the shell behavior):

-- >8 --
$ git version &&
  mkdir test && cd test && git init &&
  touch file && git add file && git commit -m added &&
  echo content >file && git commit -a -m updated &&
  echo done
git version 1.5.3.6.2090.g4ece0
Initialized empty Git repository in .git/
Created initial commit b3cbe63: added
 0 files changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 file

Created commit 7a6b446: updated
 1 files changed, 1 insertions(+), 0 deletions(-)

done -- 8< --

where the shell behavior omits the extra newlines. Is there some other input for which log_tree_commit actually needs the newline?

-Peff