Re: [PATCH 6/6] builtin-commit: Add newline when showing which commit was created

From: Jeff King <peff@peff.net>
Date: Dec 2, 2007, 16:54 UTC
Message-ID: <20071202165409.GA30998@coredump.intra.peff.net>
In-Reply-To: <Pine.LNX.4.64.0712021212490.27959@racer.site>

On Sun, Dec 02, 2007 at 12:13:07PM +0000, Johannes Schindelin wrote:

> > It would be helpful if you could remember the test case, but perhaps
> > that is not an option at this point.
> 
> IIRC it was "git commit -m bla".

I have made several attempts to reproduce the problem, looked a bit through the log-tree code, and checked the results of the t750* series of tests; but I have found nothing. I think we are better off reverting, which fixes every case I have seen; if the problem behavior comes back, we will have figured out what causes it. And if it doesn't come back, then the revert is the right thing. :)

-- >8 -- Revert "builtin-commit: Add newline when showing which commit was created"

This reverts commit 129fa606365c172d07a5d98bea9345277f221363.

We end up in most cases with an undesired extra newline. It
is possible that there is some corner case that requires the
newline, but there is no published test case. So let's fix
the known problem, and we can deal with the corner case if
and when there is a bug report.
---
 builtin-commit.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/builtin-commit.c b/builtin-commit.c
index f6e8e44..118853d 100644
--- a/builtin-commit.c
+++ b/builtin-commit.c
@@ -660,7 +660,6 @@ static void print_summary(const char *prefix, const unsigned char *sha1)
 	printf("Created %scommit ", initial_commit ? "initial " : "");
 
 	log_tree_commit(&rev, commit);
-	printf("\n");
 }
 
 int git_commit_config(const char *k, const char *v)

-- 
1.5.3.6.2094.g3713