From: Johannes Schindelin Date: Sun, 02 Dec 2007 17:18:24 GMT Subject: Re: [PATCH 6/6] builtin-commit: Add newline when showing which commit was created Message-ID: In-Reply-To: <20071202165409.GA30998@coredump.intra.peff.net> Hi, On Sun, 2 Dec 2007, Jeff King wrote: > On Sun, Dec 02, 2007 at 12:13:07PM +0000, Johannes Schindelin wrote: > > > > It would be helpful if you could remember the test case, but perhaps > > > that is not an option at this point. > > > > IIRC it was "git commit -m bla". > > I have made several attempts to reproduce the problem, looked a bit > through the log-tree code, and checked the results of the t750* series > of tests; but I have found nothing. I remember again. When I did "commit -s -m bla" the empty line between the oneline and the signoff would be missing. But in the meantime, the signoff was dragged into the strbuf and all is well. ACK. Ciao, Dscho