Re: [PATCH 6/6] builtin-commit: Add newline when showing which commit was created
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Dec 2, 2007, 21:20 UTC
- Message-ID
- <Pine.LNX.4.64.0712022107090.27959@racer.site>
- In-Reply-To
- <7vtzn1x7w6.fsf@gitster.siamese.dyndns.org>
Hi,
On Sun, 2 Dec 2007, Junio C Hamano wrote:
Show 17 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > >> I have made several attempts to reproduce the problem, looked a bit > >> through the log-tree code, and checked the results of the t750* series > >> of tests; but I have found nothing. > > > > I remember again. When I did "commit -s -m bla" the empty line between > > the oneline and the signoff would be missing. But in the meantime, the > > signoff was dragged into the strbuf and all is well. > > Sorry, now I am confused. Building the version before that change and > doing "./git-commit -a -s -m bla", I do not see the extra blank line in > the "Created commit" response, and I see a blank line before and after > the sign-off in the "git show" output for the resulting commit. > > Was this unnecessary change from the beginning? I am inclined to think > so...
IIRC I did 2150554b0ed60356d8918b610834c04ad2eecdec(builtin-commit --s: add a newline if the last line was no S-O-B) after the commit that Peff wants to undo.
So yes, my mistake.
Ciao, Dscho