git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/6] builtin-commit: Add newline when showing which commit was created

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 2, 2007, 21:20 UTC
Message-ID
<Pine.LNX.4.64.0712022107090.27959@racer.site>
In-Reply-To
<7vtzn1x7w6.fsf@gitster.siamese.dyndns.org>
Hi,
On Sun, 2 Dec 2007, Junio C Hamano wrote:
Show 17 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> >> I have made several attempts to reproduce the problem, looked a bit
> >> through the log-tree code, and checked the results of the t750* series
> >> of tests; but I have found nothing.
> >
> > I remember again.  When I did "commit -s -m bla" the  empty line between 
> > the oneline and the signoff would be missing.  But in the meantime, the 
> > signoff was dragged into the strbuf and all is well.
> 
> Sorry, now I am confused.  Building the version before that change and
> doing "./git-commit -a -s -m bla", I do not see the extra blank line in
> the "Created commit" response, and I see a blank line before and after
> the sign-off in the "git show" output for the resulting commit.
> 
> Was this unnecessary change from the beginning?  I am inclined to think
> so...

IIRC I did 2150554b0ed60356d8918b610834c04ad2eecdec(builtin-commit --s: add a newline if the last line was no S-O-B) after the commit that Peff wants to undo.

So yes, my mistake.

Ciao, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 22 of 24 in “Various (replacement) patches to builtin-commit”
  1. 0/6 Various (replacement) patches to builtin-commitJohannes Schindelin, Nov 11, 2007
  2. 1/6 builtin-commit: fix author date with --amend --author=<author>Johannes Schindelin, Nov 11, 2007
  3. Kristian HøgsbergNov 12, 2007
  4. Johannes SchindelinNov 12, 2007
  5. Junio C HamanoNov 13, 2007
  6. 2/6 git status: show relative paths when run in a subdirectoryJohannes Schindelin, Nov 11, 2007
  7. 3/6 builtin-commit: fix --signoffJohannes Schindelin, Nov 11, 2007
  8. 4/6 builtin-commit --s: add a newline if the last line was no S-O-BJohannes Schindelin, Nov 11, 2007
  9. 5/6 builtin-commit: resurrect behavior for multiple -m optionsJohannes Schindelin, Nov 11, 2007
  10. Pierre HabouzitNov 11, 2007
  11. Johannes SchindelinNov 11, 2007
  12. Pierre HabouzitNov 11, 2007
  13. Pierre HabouzitNov 11, 2007
  14. 6/6 builtin-commit: Add newline when showing which commit was createdJohannes Schindelin, Nov 11, 2007
  15. Jeff KingDec 1, 2007
  16. Johannes SchindelinDec 1, 2007
  17. Jeff KingDec 2, 2007
  18. Johannes SchindelinDec 2, 2007
  19. Jeff KingDec 2, 2007
  20. Johannes SchindelinDec 2, 2007
  21. Junio C HamanoDec 2, 2007
  22. Johannes SchindelinDec 2, 2007
  23. Junio C HamanoDec 3, 2007
  24. Jeff KingDec 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.