Re: [PATCH 6/6] builtin-commit: Add newline when showing which commit was created

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 3, 2007, 07:33 UTC
Message-ID: <7vzlwsmdvb.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071201222106.GA27102@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 11 quoted lines

> On Sun, Nov 11, 2007 at 05:36:52PM +0000, Johannes Schindelin wrote:
>
>> The function log_tree_commit() does not break the line, so we have to
>> do it ourselves.
>
> Johannes,
>
> Can you explain the rationale for this change in more detail?
>
> When I run builtin-commit from the tip of next, I always get an extra
> newline (as compared to the shell behavior):

After reverting this, recording a merge commit seems to have lost the newline. Can be easily reproduced with:

	$ git merge --no-commit some-branch
        $ git commit -a -m 'foo'