Re: [PATCH 2/3] send-email: drop misleading function prototype
On Sun, Mar 31, 2013 at 9:40 PM, Junio C Hamano <gitster@pobox.com> wrote:
> The subroutine check_file_rev_conflict() is called from two places,
> both of which expects to pass a single scaler variable and see if
s/scaler/scalar/g
(note the /g)
Show 8 quoted lines
> that can be interpreted as a pathname or a revision name. It is
> defined with a function prototype ($) to force a scaler context
> while evaluating the arguments at the calling site but it does not
> help the current calling sites. The only effect it has is to hurt
> future calling sites that may want to build an argument list in an
> array variable and call it as check_file_rev_confict(@args).
>
> Drop the misleading prototype, as Perlcritic suggests.
Eric Sunshine <sunshine@sunshineco.com>