Re: [PATCH 3/3] send-email: use the three-arg form of open in recipients_cmd

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Apr 1, 2013, 02:30 UTC
Message-ID: <20130401023003.GD11704@elie.Belkin>
In-Reply-To: <1364780442-6015-3-git-send-email-gitster@pobox.com>

Junio C Hamano wrote:

Show 10 quoted lines

>               we cannot rewrite it to
>
> 	open my $fh, "-|", $cmd, $file;
>
> for extra safety.  At least, by using this in the three-arg form:
>
> 	open my $fh, "-|", "$cmd \Q$file\E";
>
> we can silence Perlcritique, even though we do not gain much safety
> by doing so.

Yeah, I think this is the right thing to do.

This means that if some later code refactoring parses $tocmd once and passes an array around, it would be easy to change this to

	open my $fh, "-|", @$cmd, $file;

and there would be no temptation to do something involving pasting @$cmd back together into a single string. Of course such a refactoring is not very likely, but that kind of thing is a good reason to prefer this style in general.

So for what it's worth, I like this patch.