Re: [PATCH 1/3] send-email: use "return;" not "return undef;" on error codepaths

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Apr 2, 2013, 07:59 UTC
Message-ID: <CALkWK0muF2Nx=ykD6jt4pvpmp9c3R2KhXhQMjLAyMWiHu_6iPA@mail.gmail.com>
In-Reply-To: <1364780442-6015-1-git-send-email-gitster@pobox.com>

Junio C Hamano wrote:

Show 6 quoted lines

> Note that we leave "return undef;" in validate_address on purpose,
> even though Perlcritic may complain.  The primary "return" site of
> the function returns whatever is in the scaler variable $address, so
> it is pointless to change only the other "return undef;" to "return".
> The caller must be prepared to see an array with a single undef as
> the return value from this subroutine anyway.

The way I understood it: All callsites only ever call validate_address via validate_address_list, which in turn maps a list of addresses by calling validate_address on each address. Therefore, validate_address returning an undef in one codepath is correct.