Re: [PATCH v2] git-send-email.perl: implement suggestions made by perlcritic

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 1, 2013, 01:39 UTC
Message-ID: <7vr4ivni5g.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CALkWK0nGZUV9umbe9UoV79QU+ojCc-=j+RFpCNn_vjM_QTPyPQ@mail.gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

Show 9 quoted lines

> Junio C Hamano wrote:
>>     sub foo ($) { my ($arg) = @_; print "$arg\n"; }
>>     sub bar     { my ($arg) = @_; print "$arg\n"; }
>>     my @baz = (100, 101, 102);
>>     foo @baz; # says 3
>>     bar @baz; # says 100
>
> Ouch.  Please drop this patch; I'll resubmit when I feel confident
> about my change.

No, let's not do that. I will forget and end up spending time to read the same patch again.