Re: [PATCH v2] git-send-email.perl: implement suggestions made by perlcritic
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Mar 31, 2013, 20:59 UTC
- Message-ID
- <CALkWK0nGZUV9umbe9UoV79QU+ojCc-=j+RFpCNn_vjM_QTPyPQ@mail.gmail.com>
- In-Reply-To
- <7vsj3fs22i.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
Show 5 quoted lines
> sub foo ($) { my ($arg) = @_; print "$arg\n"; }
> sub bar { my ($arg) = @_; print "$arg\n"; }
> my @baz = (100, 101, 102);
> foo @baz; # says 3
> bar @baz; # says 100Ouch. Please drop this patch; I'll resubmit when I feel confident about my change.
> This patch fell under the cracks, and reminding me with a "what > happened to it?" was the right thing to do. Literally, that is what > I ask in the "Notes from the maintainer" message.
Right. Thanks for clarifying. I'll actively track the patches I submit.