From: Eric Sunshine Date: Mon, 01 Apr 2013 04:09:13 GMT Subject: Re: [PATCH 2/3] send-email: drop misleading function prototype Message-ID: In-Reply-To: <1364780442-6015-2-git-send-email-gitster@pobox.com> On Sun, Mar 31, 2013 at 9:40 PM, Junio C Hamano wrote: > The subroutine check_file_rev_conflict() is called from two places, > both of which expects to pass a single scaler variable and see if s/scaler/scalar/g (note the /g) > that can be interpreted as a pathname or a revision name. It is > defined with a function prototype ($) to force a scaler context > while evaluating the arguments at the calling site but it does not > help the current calling sites. The only effect it has is to hurt > future calling sites that may want to build an argument list in an > array variable and call it as check_file_rev_confict(@args). > > Drop the misleading prototype, as Perlcritic suggests.