git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 13/16] promisor-remote: introduce promisor.acceptFromServerUrl

From
Christian Couder <christian.couder@gmail.com>
Date
Apr 27, 2026, 12:44 UTC
Message-ID
<CAP8UFD3AWRjgKnwdppS7=Q7WL5pO3r1T_e61ZPqm15W8aY3mxg@mail.gmail.com>
In-Reply-To
<acUkzY7f5302uWD8@pks.im>
On Thu, Mar 26, 2026 at 1:21 PM Patrick Steinhardt <ps@pks.im> wrote:
Show 40 quoted lines
>
> On Mon, Mar 23, 2026 at 09:05:16AM +0100, Christian Couder wrote:
> > diff --git a/promisor-remote.c b/promisor-remote.c
> > index c2f0eb7223..4cb18e1a6a 100644
> > --- a/promisor-remote.c
> > +++ b/promisor-remote.c
> [snip]
> > +static struct string_list *accept_from_server_url(struct repository *repo)
> > +{
> > +     static struct string_list accept_urls = STRING_LIST_INIT_DUP;
> > +     static int initialized;
> > +     const struct string_list *config_urls;
> > +
> > +     if (initialized)
> > +             return &accept_urls;
> > +
> > +     initialized = 1;
> > +
> > +     if (!repo_config_get_string_multi(repo, "promisor.acceptfromserverurl", &config_urls)) {
> > +             struct string_list_item *item;
> > +
> > +             for_each_string_list_item(item, config_urls) {
> > +                     struct allowed_url *allowed = valid_accept_url(item->string);
> > +                     if (allowed) {
> > +                             struct string_list_item *new;
> > +                             new = string_list_append(&accept_urls, item->string);
> > +                             new->util = allowed;
> > +                     }
> > +             }
> > +     }
> > +
> > +     return &accept_urls;
> > +}
>
> I'm still not much of a fan of us getting more and more function-local
> static variables. It just feels wrong to me, and like we're accruing
> technical debt. I also doubt that the performance overhead of storing
> this on the stack with proper lifecycle management will matter at all
> given that we're in a context where we talk with a remote anyway. The
> handful of allocations really shouldn't matter in that context.
OK, I have removed the static variables and it looks like the following in v2:
+static void load_accept_from_server_url(struct repository *repo,
+                                       struct string_list *accept_urls)
+{
+       const struct string_list *config_urls;
+
+       if (!repo_config_get_string_multi(repo,
"promisor.acceptfromserverurl", &config_urls)) {
+               struct string_list_item *item;
+
+               for_each_string_list_item(item, config_urls) {
+                       struct allowed_url *allowed =
valid_accept_url(item->string);
+                       if (allowed) {
+                               struct string_list_item *new;
+                               new = string_list_append(accept_urls,
item->string);
+                               new->util = allowed;
+                       }
+               }
+       }
+}
+
 static int should_accept_remote(enum accept_promisor accept,
                                struct promisor_info *advertised,
                                struct string_list *config_info)
@@ -901,6 +986,10 @@ static void filter_promisor_remote(struct repository *repo,
        struct string_list_item *item;
        bool reload_config = false;
        enum accept_promisor accept = accept_from_server(repo);
+       struct string_list accept_urls = STRING_LIST_INIT_DUP;
+
+       /* Load and validate the acceptFromServerUrl config */
+       load_accept_from_server_url(repo, &accept_urls);


        if (accept == ACCEPT_NONE)
                return;
Previous: Patrick SteinhardtNext: Christian Couder
Message 30 of 47 in “Auto-configure advertised remotes via URL whitelist”
  1. 00/16 Auto-configure advertised remotes via URL whitelistChristian Couder, Mar 23, 2026
  2. 01/16 promisor-remote: try accepted remotes before others in get_direct()Christian Couder, Mar 23, 2026
  3. Patrick SteinhardtMar 26, 2026
  4. Christian CouderApr 2, 2026
  5. 02/16 urlmatch: change 'allow_globs' arg to boolChristian Couder, Mar 23, 2026
  6. 03/16 urlmatch: add url_is_valid_pattern() helperChristian Couder, Mar 23, 2026
  7. Patrick SteinhardtMar 26, 2026
  8. Christian CouderApr 27, 2026
  9. 04/16 promisor-remote: clarify that a remote is ignoredChristian Couder, Mar 23, 2026
  10. Patrick SteinhardtMar 26, 2026
  11. Christian CouderApr 2, 2026
  12. 05/16 promisor-remote: refactor has_control_char()Christian Couder, Mar 23, 2026
  13. 06/16 promisor-remote: refactor accept_from_server()Christian Couder, Mar 23, 2026
  14. 07/16 promisor-remote: keep accepted promisor_info structs aliveChristian Couder, Mar 23, 2026
  15. Patrick SteinhardtMar 26, 2026
  16. 08/16 promisor-remote: remove the 'accepted' strvecChristian Couder, Mar 23, 2026
  17. Patrick SteinhardtMar 26, 2026
  18. Christian CouderApr 2, 2026
  19. 09/16 promisor-remote: add 'local_name' to 'struct promisor_info'Christian Couder, Mar 23, 2026
  20. Patrick SteinhardtMar 26, 2026
  21. Christian CouderApr 27, 2026
  22. 10/16 promisor-remote: pass config entry to all_fields_match() directlyChristian Couder, Mar 23, 2026
  23. Patrick SteinhardtMar 26, 2026
  24. Christian CouderApr 2, 2026
  25. 12/16 t5710: use proper file:// URIs for absolute pathsChristian Couder, Mar 23, 2026
  26. Patrick SteinhardtMar 26, 2026
  27. Christian CouderApr 2, 2026
  28. 13/16 promisor-remote: introduce promisor.acceptFromServerUrlChristian Couder, Mar 23, 2026
  29. Patrick SteinhardtMar 26, 2026
  30. Christian CouderApr 27, 2026
  31. 11/16 promisor-remote: refactor should_accept_remote() control flowChristian Couder, Mar 23, 2026
  32. Patrick SteinhardtMar 26, 2026
  33. Christian CouderApr 2, 2026
  34. 14/16 promisor-remote: trust known remotes matching acceptFromServerUrlChristian Couder, Mar 23, 2026
  35. Junio C HamanoMar 23, 2026
  36. Junio C HamanoMar 23, 2026
  37. Christian CouderMar 27, 2026
  38. Junio C HamanoMar 31, 2026
  39. Christian CouderApr 1, 2026
  40. Patrick SteinhardtMar 26, 2026
  41. Christian CouderApr 27, 2026
  42. 16/16 doc: promisor: improve acceptFromServer entryChristian Couder, Mar 23, 2026
  43. 15/16 promisor-remote: auto-configure unknown remotesChristian Couder, Mar 23, 2026
  44. Patrick SteinhardtMar 26, 2026
  45. Christian CouderApr 27, 2026
  46. Patrick SteinhardtMar 26, 2026
  47. Christian CouderApr 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.