Re: [PATCH 15/16] promisor-remote: auto-configure unknown remotes
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Apr 27, 2026, 12:44 UTC
- Message-ID
- <CAP8UFD20=ArLUDbD36=02_i2io8+uMYhm5LJVGayzKYOkqmMBg@mail.gmail.com>
- In-Reply-To
- <acUk11mt06GJZaur@pks.im>
On Thu, Mar 26, 2026 at 1:21 PM Patrick Steinhardt <ps@pks.im> wrote:
Show 23 quoted lines
> > On Mon, Mar 23, 2026 at 09:05:18AM +0100, Christian Couder wrote: > > Previous commits have introduced the `promisor.acceptFromServerUrl` > > config variable to whitelist some URLs advertised by a server through > > the "promisor-remote" protocol capability. > > > > However the new `promisor.acceptFromServerUrl` mechanism, like the old > > `promisor.acceptFromServer` mechanism, still requires a remote to > > already exist in the client's local configuration before it can be > > accepted. This places a significant manual burden on users to > > pre-configure these remotes, and creates friction for administrators > > who have to troubleshoot or manually provision these setups for their > > teams. > > > > To eliminate this burden, let's automatically create a new `[remote]` > > section in the client's config when a server advertises an unknown > > remote whose URL matches a `promisor.acceptFromServerUrl` glob pattern. > > Would it make sense to extend git-clone(1) to have a command line option > that basically does this as a one-shot? Something like `git clone > --accept-promisors=url:https://gitlab.com/*`? I assume that many users > may not want to keep on updating their configured promisors all the > time.
I don't understand why you say "many users may not want to keep on updating their configured promisors all the time". It seems to me that what I propose requires even less effort from users than what you suggest.
If users set up something like:
git config set --global promisor.acceptFromServerUrl "https://my-org.com/*"
or:
git config set --global promisor.acceptFromServerUrl "https://gitlab.com/my-org/*"
they would then automatically accept the promisor remotes with an URL matching the pattern when they make a partial clone.
So it's a one time setup instead of having to use `--accept-promisors=url:...` each time they clone.
Also `git -c promisor.acceptFromServerUrl="..." clone` can basically be used to get the same thing as the `--accept-promisors=url:...` flag you suggest.
Show 8 quoted lines
> Furthermore, this here reconfirms my thought on the previous commit that > it would make sense to detangle accepting promisors, storing them in the > configuration and updating them automatically. These are all different > things: > > - Accepting promisors is basically an ongoing runtime thing where you > start to use announced promisors even though they are not configured > at all.
Why an "ongoing runtime thing"? If users think it's fine to accept promisors from their own domain, why should they have to confirm that every time they clone?
> - Storing promisors is typically a one-time thing that you'd want to > do when creating a new repository.
Except that some fields and maybe sometimes URLs might change on the server side and it would be nice if this didn't require manual updates on the client side.
> - Updating promisors automatically is probably something you want to > do on an ongoing basis when you have stored promisors.
Yeah, so it's similar in many ways to storing promisors.
> We're currently putting all of these use cases into the same bag, but > they have very different characteristics.
I don't think all use cases are put in the same bag. There are a number of config options already that allow a lot of customization. Adding "promisor.acceptFromServerUrl" as a separate option from "promisor.acceptFromServer" also only increases the possibilities for users.
> I guess the most common use > case will eventually be to never auto-accept promisors, store them at > clone time, and keep them updated whenever they change.
I am not sure at all this is the most common use case.
If you require a `--accept-promisors=url:https://my-org.com/*` each time, people might just copy-paste it or create an alias for that and then use it all the time and you won't get much more security than something like:
git config set --global promisor.acceptFromServerUrl "https://my-org.com/*"
once and then regular `git clone ...`
When users have to often pass parameters manually, the typos and misconfiguration risks also increase compared to admins setting things up globally for everyone, or even users doing it once for themselves.
> This cannot be > expressed with "promisor.acceptFromServerUrl" as far as I understand.
`git -c promisor.acceptFromServerUrl="..." clone` is basically the same as the option you suggest.