Re: [PATCH 04/16] promisor-remote: clarify that a remote is ignored
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Apr 2, 2026, 07:03 UTC
- Message-ID
- <CAP8UFD12BQUZOq4wfkthUE2No_ozrzhETKRWZgfgOha8UviuKg@mail.gmail.com>
- In-Reply-To
- <acUkqRUSyRUysf-I@pks.im>
On Thu, Mar 26, 2026 at 1:21 PM Patrick Steinhardt <ps@pks.im> wrote:
Show 11 quoted lines
> > On Mon, Mar 23, 2026 at 09:05:07AM +0100, Christian Couder wrote: > > In should_accept_remote() when a remote is ignored, we might tell users > > why it is ignored in a warning, but we don't tell them that the remote > > is actually ignored. > > > > Let's clarify that, so users have a better idea of what's actually > > happening. > > Interesting that this doesn't result in any test changes. Don't we have > test coverage for `should_accept_remote()`?
We have test coverage but we don't test the emitted warning, we test whether the remote is actually accepted and used.
Let me know if you think we should test the warnings too.