Re: [PATCH 14/16] promisor-remote: trust known remotes matching acceptFromServerUrl
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Apr 1, 2026, 05:41 UTC
- Message-ID
- <CAP8UFD2HsfNGX6LrthBX0SqXUpgwiGyT3R2X1zwHN9SribAqgw@mail.gmail.com>
- In-Reply-To
- <xmqq341fy7v4.fsf@gitster.g>
On Wed, Apr 1, 2026 at 12:03 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 16 quoted lines
> > Christian Couder <christian.couder@gmail.com> writes: > > >> Between the first sentence and the second one, I think there needs > >> to be an explanation on what "trusted" means in this context. Is it > >> trusted so that the URL can feed random configuration variable=value > >> pairs for the client to blindly apply? Or is it trusted to do very > >> limited things that other remotes can do, and if so what are these > >> limited things? Without knowing that, the end-users cannot assess > >> the security implications of setting this option. > > > > Yeah, in the current version, the following is used, which is more explicit: > > ... > > Do you mean by "the current version", the one you are preparing as > an updated iteration?
Yes, but I am going to split the series as Patrick suggested into:
1) a preparatory series which adds fixes, refactorings and cleanups, 2) a series which adds the new features related to the new `acceptFromServerUrl` config variable.
I will send 1) soon, and 2) later when it looks like 1) has graduated or will graduate soon.
> If so, let me mark the topic to be expecting a reroll. From the > reviews by Patrick, I am not sure if I should also add the usual > "(hopefully small and final)" in this case, not just yet, though.
You can also just drop it or mark it as superseded by 1) when I have sent it.
Thanks.