Re: [PATCH 08/16] promisor-remote: remove the 'accepted' strvec
On Thu, Mar 26, 2026 at 1:21 PM Patrick Steinhardt <ps@pks.im> wrote:
Show 12 quoted lines
>
> On Mon, Mar 23, 2026 at 09:05:11AM +0100, Christian Couder wrote:
> > In a previous commit, filter_promisor_remote() was refactored to keep
> > accepted 'struct promisor_info' instances alive instead of dismantling
> > them into separate parallel data structures.
> >
> > Let's go one step further and replace the 'struct strvec *accepted'
> > argument passed to filter_promisor_remote() with a
> > 'struct string_list *accepted_remotes' argument.
>
> Right, this is indeed something I was wondering about given that we now
> effectively stored the remote name twice.
Yeah, I think both patches together result in a nice code simplification.
Thanks for taking a close look at them.