Re: [RFC/PATCH 09/11] branch.c: use 'ref-filter' data structures

From: Christian Couder <christian.couder@gmail.com>
Date: Jul 28, 2015, 08:22 UTC
Message-ID: <CAP8UFD1Bx_o2gWP0R4EbsHO0d3LRRJ2rpHDKQhRVQpTrD6pjBw@mail.gmail.com>
In-Reply-To: <1438066594-5620-9-git-send-email-Karthik.188@gmail.com>

On Tue, Jul 28, 2015 at 8:56 AM, Karthik Nayak <karthik.188@gmail.com> wrote:

Show 17 quoted lines

> diff --git a/ref-filter.h b/ref-filter.h
> index 7d1871d..3458595 100644
> --- a/ref-filter.h
> +++ b/ref-filter.h
> @@ -5,6 +5,7 @@
>  #include "refs.h"
>  #include "commit.h"
>  #include "parse-options.h"
> +#include "revision.h"
>
>  /* Quoting styles */
>  #define QUOTE_NONE 0
> @@ -48,6 +49,7 @@ struct ref_sorting {
>  struct ref_array_item {
>         unsigned char objectname[20];
>         int flag, kind;
> +       int ignore : 1;

Maybe you could add a comment to say that this will be removed in the next patch.

>         const char *symref;
>         struct commit *commit;
>         struct atom_value *value;