Re: [RFC/PATCH 03/11] ref-filter: add option to filter only branches
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Jul 28, 2015, 16:42 UTC
- Message-ID
- <CAOLa=ZTkSDqgTYH1fmcGssSPbkbr8RN3zGMrbZPx9pWQCfs+9A@mail.gmail.com>
- In-Reply-To
- <vpqio94wgf9.fsf@anie.imag.fr>
On Tue, Jul 28, 2015 at 7:08 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
Show 18 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> +static int filter_branch_kind(struct ref_filter *filter, const char *refname)
>> +{
>> + int kind, i;
>> +
>> + static struct {
>> + int kind;
>> + const char *prefix;
>> + } ref_kind[] = {
>> + { REF_LOCAL_BRANCH, "refs/heads/" },
>> + { REF_REMOTE_BRANCH, "refs/remotes/" },
>> + };
>
> Nit: I would swap the order of fields, to make it a bit clearer that
> this is a kind of dictionary key -> value (I think it's more common to
> write it in this order than value <- key).
>This was borrowed from branch.c, but ok will change it! Thanks
-- Regards, Karthik Nayak