Re: [RFC/PATCH 02/11] ref-filter: add 'colornext' atom
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Jul 28, 2015, 16:04 UTC
- Message-ID
- <CAOLa=ZSz8xpDD5LJ3AW6xszTJxCU8EK71V2LJcymB14-ebhnZQ@mail.gmail.com>
- In-Reply-To
- <CAP8UFD2x5rz18hUXmJVWw81EMEVZc5Hm=_GUwfuc6Fo--8Ukfw@mail.gmail.com>
On Tue, Jul 28, 2015 at 2:43 PM, Christian Couder <christian.couder@gmail.com> wrote:
Show 13 quoted lines
> On Tue, Jul 28, 2015 at 8:56 AM, Karthik Nayak <karthik.188@gmail.com> wrote:
>> @@ -712,6 +713,15 @@ static void populate_value(struct ref_array_item *ref)
>> v->modifier_atom = 1;
>> v->pad_to_right = 1;
>> continue;
>> + } else if (starts_with(name, "colornext:")) {
>> + char color[COLOR_MAXLEN] = "";
>> +
>> + if (color_parse(name + 10, color) < 0)
>> + die(_("unable to parse format"));
>
> Maybe use skip_prefix(), and die() with a more helpful message.
>Okay will do. Thanks!
-- Regards, Karthik Nayak