Re: [RFC/PATCH 01/11] ref-filter: add "%(objectname:size=X)" option
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Jul 28, 2015, 15:54 UTC
- Message-ID
- <CAOLa=ZSWb6CKp2M6QRkSmdyf6XNJ_9kYTOuPHiw2_cU6JU3MHQ@mail.gmail.com>
- In-Reply-To
- <vpqio941xn5.fsf@anie.imag.fr>
On Tue, Jul 28, 2015 at 2:12 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
Show 13 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> + if (skip_prefix(name, "objectname:size=", &p)) {
>> + unsigned int size = atoi(p);
>
> You have the same problem as for tag.c: don't use atoi, and make
> accurate error checking (absence of value, negative value, non-integer
> value).
>
> If you have other higher-priorities task, leave a temporary comment
> /* FIXME: ... */ or /* TODO: ... */ and make sure you have no such
> comment when you drop the "RFC" in the subject of your emails.
>It's a small change, will fix it with the drop in RFC :)
-- Regards, Karthik Nayak