Re: [RFC/PATCH 04/11] ref-filter: add 'ifexists' atom
On Tue, Jul 28, 2015 at 1:24 PM, Jacob Keller <jacob.keller@gmail.com> wrote:
Show 8 quoted lines
> On Mon, Jul 27, 2015 at 11:56 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
>> The 'ifexists' atom allows us to print a required format if the
>> preceeding atom has a value. If the preceeding atom has no value then
>
> Don't you mean "following atom" here? since you do document it as "the
> next atom" below you should fix the commit message as well to match.
> In any respect, this is a useful formatting atom :)
>
That should have been `succeeding` atom. My bad! thanks :)
Show 6 quoted lines
> %(ifexists:[%s])%(atom) where the contents of atom will be placed into %s?
>
> I suggest documenting that the atom will be placed into the contents
> of ifexists via the %s indicator, as you do show an example but don't
> explicitely say %s is the formatting character.
>
Yeah! I should have explicitly mentioned that, thanks!
--
Regards,
Karthik Nayak
Karthik Nayak <karthik.188@gmail.com>