Re: [PATCH v2 10/14] For each exclude pattern, store information about where it came from
- From
Adam Spiers <git@adamspiers.org>
- Date
- Dec 26, 2012, 15:46 UTC
- Message-ID
- <CAOkDyE-HEAiBPyLLTRs2gY1C9uBSmX+xG6NqzLeoWh-oYb0LUA@mail.gmail.com>
- In-Reply-To
- <7vzk4k8joy.fsf@alter.siamese.dyndns.org>
On Thu, Sep 20, 2012 at 02:31:57PM -0700, Junio C Hamano wrote:
Show 17 quoted lines
> Adam Spiers <git@adamspiers.org> writes:
>
> > void add_exclude(const char *string, const char *base,
> > - int baselen, struct exclude_list *el)
> > + int baselen, struct exclude_list *el, const char *src, int srcpos)
> > {
> > struct exclude *x;
> > size_t len;
> > @@ -341,6 +341,8 @@ void add_exclude(const char *string, const char *base,
> > x->base = base;
> > x->baselen = baselen;
> > x->flags = flags;
> > + x->src = src;
> > + x->srcpos = srcpos;
>
> Hrm, don't all elements "x" in "el" share the same "src", even if
> their srcpos may be different?No not currently - please see the other mail I just sent to the [PATCH v2 00/14] thread.