Re: [PATCH v2 14/14] Add git-check-ignore sub-command
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 26, 2012, 14:03 UTC
- Message-ID
- <7vy5jwubig.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <50629765.2060107@viscovery.net>
Johannes Sixt <j.sixt@viscovery.net> writes:
Show 13 quoted lines
>> These days, we do not add random subcommands willy-nilly (I still >> doubt if check-ignore needs to be a separate debugging command, or a >> new mode of operation of ls-files or something), so the approach to >> use a blacklist makes more sense. "help -a" is designed to show >> whatever the users throw in their ~/bin (assuming that is on $PATH) >> under git-whatever name, and we _do_ want to complete "git wh<TAB>" >> to that custom command, so a whitelist-based solution is unwieldy to >> construct. > > We already have 'git check-attr', but it is obviously not among the > autocompleted commands, otherwise the above test would not have passed. > IMO, 'git check-ignore' falls into the same category as 'git check-attr' > with regard to completion.
Exactly.
Actually I think what happened was that the submitter didn't have change to contrib/completion/ in earlier private versions, saw the test fail and updated t9902 without thinking. The patch posted has addition to contrib/completion/ that blacklists check-ignore the same way as check-attr, which made the change to t9902 unnecessary but because the update was done without thinking, it wasn't even realized that the test would have passed without the patch to it.
Reverting the part that touches t9902 should still pass, I would think.
t/t9902-completion.sh | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
diff --git c/t/t9902-completion.sh w/t/t9902-completion.sh index cce51ac..92d7eb4 100755 --- c/t/t9902-completion.sh +++ w/t/t9902-completion.sh @@ -213,19 +213,19 @@ test_expect_success 'general options' ' ' test_expect_success 'general options plus command' ' - test_completion "git --version checko" "checkout " && - test_completion "git --paginate checko" "checkout " && - test_completion "git --git-dir=foo checko" "checkout " && - test_completion "git --bare checko" "checkout " && + test_completion "git --version check" "checkout " && + test_completion "git --paginate check" "checkout " && + test_completion "git --git-dir=foo check" "checkout " && + test_completion "git --bare check" "checkout " && test_completion "git --help des" "describe " && - test_completion "git --exec-path=foo checko" "checkout " && - test_completion "git --html-path checko" "checkout " && - test_completion "git --no-pager checko" "checkout " && - test_completion "git --work-tree=foo checko" "checkout " && - test_completion "git --namespace=foo checko" "checkout " && - test_completion "git --paginate checko" "checkout " && - test_completion "git --info-path checko" "checkout " && - test_completion "git --no-replace-objects checko" "checkout " + test_completion "git --exec-path=foo check" "checkout " && + test_completion "git --html-path check" "checkout " && + test_completion "git --no-pager check" "checkout " && + test_completion "git --work-tree=foo check" "checkout " && + test_completion "git --namespace=foo check" "checkout " && + test_completion "git --paginate check" "checkout " && + test_completion "git --info-path check" "checkout " && + test_completion "git --no-replace-objects check" "checkout " ' test_done