git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Fix notes handling in rev-list

From
JLJukka Lehtniemi <jukka.lehtniemi@gmail.com>
Date
Jul 17, 2012, 21:22 UTC
Message-ID
<CAOQ7pMO8w79B1kpztv4a+x8oCSzL4b8t7STyQu2i68ZT6qk_wQ@mail.gmail.com>
In-Reply-To
<7vvchnx7tc.fsf@alter.siamese.dyndns.org>

First of all, thanks for you feedback, both of you. And sorry for wasting your time . I thought that the "In-Reply-To"-header would serve as a reference to the original patch but obviously it wasn't enough.

On Tue, Jul 17, 2012 at 8:42 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
>
> I wonder if we should show the blob object names that store the
> notes payload if we were given --notes option in a format that is
> easy for readers to mechanically parse its output.
>

Very good point indeed. I think this is how it should be. How would you prefer the output format to be? Would e.g.

    189899d229ec Notes: 888ecad77e88
be ok?
Show 7 quoted lines
> In any case, the use of format_display_notes() that is meant for
> human consumption feels very wrong to me, especially it seems to be
> placed outside the "if (revs->verbose_header && commit->buffer)"
> block in this patch.  I do not have any problem if the patch makes
> the notes text shown in the other side of the if block that uses
> pretty_print_commit(), though.
>

I think that another place where human readable notes should be shown is inside the graph.

-- 
Jukka
Previous: Junio C HamanoNext: Jeff King
Message 10 of 15 in “rev-list: fix place holder %N (notes) in user format”
  1. rev-list: fix place holder %N (notes) in user formatJukka Lehtniemi, Mar 24, 2012
  2. Jeff KingMar 25, 2012
  3. Fix notes handling in rev-listJukka Lehtniemi, Jul 16, 2012
  4. Junio C HamanoJul 16, 2012
  5. Jeff KingJul 17, 2012
  6. Junio C HamanoJul 17, 2012
  7. Jeff KingJul 17, 2012
  8. Jeff KingJul 17, 2012
  9. Junio C HamanoJul 17, 2012
  10. Jukka LehtniemiJul 17, 2012
  11. Jeff KingJul 18, 2012
  12. Junio C HamanoJul 18, 2012
  13. Jeff KingJul 19, 2012
  14. Junio C HamanoJul 19, 2012
  15. Jeff KingJul 19, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.