git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Fix notes handling in rev-list

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 16, 2012, 19:03 UTC
Message-ID
<7vipdn1qb7.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1342463409-6919-1-git-send-email-jukka.lehtniemi@gmail.com>
Jukka Lehtniemi <jukka.lehtniemi@gmail.com> writes:
Show 8 quoted lines
> Display notes in the rev-list when switch '--notes' is used.
> Also expand notes place holder (%N) in user format.
> Previously rev-list ignored both of these.
>
> Signed-off-by: Jukka Lehtniemi <jukka.lehtniemi@gmail.com>
> ---
>
> Thanks for your feedback Peff!

If it is an update for some old patch (I am guessing that is the case from "v2" and "feedback" above), please hint where the original can be found not to waste reviewers' time.

As "git rev-list -h" does not say anything about "notes", I do not think this should be even called "Fix"; rather it is "teach rev-list to show notes with --notes", a new feature.

And as a new feature, "git rev-list -h" should be taught to include this new option in its output. I didn't check the documentation but you may also want to add --notes there, too (hint: grep for "--pretty" to find where you may need to add the new option).

Previous: Jukka LehtniemiNext: Jeff King
Message 4 of 15 in “rev-list: fix place holder %N (notes) in user format”
  1. rev-list: fix place holder %N (notes) in user formatJukka Lehtniemi, Mar 24, 2012
  2. Jeff KingMar 25, 2012
  3. Fix notes handling in rev-listJukka Lehtniemi, Jul 16, 2012
  4. Junio C HamanoJul 16, 2012
  5. Jeff KingJul 17, 2012
  6. Junio C HamanoJul 17, 2012
  7. Jeff KingJul 17, 2012
  8. Jeff KingJul 17, 2012
  9. Junio C HamanoJul 17, 2012
  10. Jukka LehtniemiJul 17, 2012
  11. Jeff KingJul 18, 2012
  12. Junio C HamanoJul 18, 2012
  13. Jeff KingJul 19, 2012
  14. Junio C HamanoJul 19, 2012
  15. Jeff KingJul 19, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.