From: Jukka Lehtniemi Date: Tue, 17 Jul 2012 21:22:32 GMT Subject: Re: [PATCH v2] Fix notes handling in rev-list Message-ID: In-Reply-To: <7vvchnx7tc.fsf@alter.siamese.dyndns.org> First of all, thanks for you feedback, both of you. And sorry for wasting your time . I thought that the "In-Reply-To"-header would serve as a reference to the original patch but obviously it wasn't enough. On Tue, Jul 17, 2012 at 8:42 AM, Junio C Hamano wrote: > > I wonder if we should show the blob object names that store the > notes payload if we were given --notes option in a format that is > easy for readers to mechanically parse its output. > Very good point indeed. I think this is how it should be. How would you prefer the output format to be? Would e.g. 189899d229ec Notes: 888ecad77e88 be ok? > In any case, the use of format_display_notes() that is meant for > human consumption feels very wrong to me, especially it seems to be > placed outside the "if (revs->verbose_header && commit->buffer)" > block in this patch. I do not have any problem if the patch makes > the notes text shown in the other side of the if block that uses > pretty_print_commit(), though. > I think that another place where human readable notes should be shown is inside the graph. -- Jukka