git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Fix notes handling in rev-list

From
Jeff King <peff@peff.net>
Date
Jul 19, 2012, 17:25 UTC
Message-ID
<20120719172550.GA12883@sigill.intra.peff.net>
In-Reply-To
<7vr4s7vfal.fsf@alter.siamese.dyndns.org>
On Thu, Jul 19, 2012 at 10:20:18AM -0700, Junio C Hamano wrote:
Show 7 quoted lines
> > So for plumbing, I think this is the wrong direction, anyway. The real
> > value of this patch is that the pretty-printed code path would work more
> > like git-log (especially the "%N" format, which lets callers make their
> > own micro-format for specifying all the bits they are interested in).
> 
> Yeah, but at that point the obvious question becomes "why you aren't
> using 'git log' in the first place".

I dunno. I guess there are other plumbing-like behaviors of rev-list that you would want, but the only ones I can think of are diff options, which rev-list does not handle at all.

> > Maybe the best thing is to simply disallow --notes when not using a
> > pretty-printed format.
> 
> Yeah, or simply ignore it.

I'd rather generate an error to make it more obvious what is happening (and it is not that we are somehow failing to find any notes). And it might help prevent the later question of: why does "git rev-list --oneline --notes" show notes, but "git rev-list --notes" silently ignores it? 

-Peff
Previous: Junio C Hamano
Message 15 of 15 in “rev-list: fix place holder %N (notes) in user format”
  1. rev-list: fix place holder %N (notes) in user formatJukka Lehtniemi, Mar 24, 2012
  2. Jeff KingMar 25, 2012
  3. Fix notes handling in rev-listJukka Lehtniemi, Jul 16, 2012
  4. Junio C HamanoJul 16, 2012
  5. Jeff KingJul 17, 2012
  6. Junio C HamanoJul 17, 2012
  7. Jeff KingJul 17, 2012
  8. Jeff KingJul 17, 2012
  9. Junio C HamanoJul 17, 2012
  10. Jukka LehtniemiJul 17, 2012
  11. Jeff KingJul 18, 2012
  12. Junio C HamanoJul 18, 2012
  13. Jeff KingJul 19, 2012
  14. Junio C HamanoJul 19, 2012
  15. Jeff KingJul 19, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.