git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Fix notes handling in rev-list

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 19, 2012, 17:20 UTC
Message-ID
<7vr4s7vfal.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120719113535.GA29774@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> Unlike elements of the commit object itself, like --parents or
> --timestamp, notes do not really gain any efficiency by being printed as
> part of the traversal. So modulo the cost of piping the list of commits,
> it would not really be any more efficient than "git rev-list | git notes
> list --stdin" (except that the latter does not take a --stdin argument,
> but could easily do so). And the latter is way more flexible.
Yeah, I prefer that (not that I think we need either badly).
> So for plumbing, I think this is the wrong direction, anyway. The real
> value of this patch is that the pretty-printed code path would work more
> like git-log (especially the "%N" format, which lets callers make their
> own micro-format for specifying all the bits they are interested in).

Yeah, but at that point the obvious question becomes "why you aren't using 'git log' in the first place".

> Maybe the best thing is to simply disallow --notes when not using a
> pretty-printed format.
Yeah, or simply ignore it.
Previous: Jeff KingNext: Jeff King
Message 14 of 15 in “rev-list: fix place holder %N (notes) in user format”
  1. rev-list: fix place holder %N (notes) in user formatJukka Lehtniemi, Mar 24, 2012
  2. Jeff KingMar 25, 2012
  3. Fix notes handling in rev-listJukka Lehtniemi, Jul 16, 2012
  4. Junio C HamanoJul 16, 2012
  5. Jeff KingJul 17, 2012
  6. Junio C HamanoJul 17, 2012
  7. Jeff KingJul 17, 2012
  8. Jeff KingJul 17, 2012
  9. Junio C HamanoJul 17, 2012
  10. Jukka LehtniemiJul 17, 2012
  11. Jeff KingJul 18, 2012
  12. Junio C HamanoJul 18, 2012
  13. Jeff KingJul 19, 2012
  14. Junio C HamanoJul 19, 2012
  15. Jeff KingJul 19, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.