git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Fix notes handling in rev-list

From
Jeff King <peff@peff.net>
Date
Jul 17, 2012, 03:51 UTC
Message-ID
<20120717035138.GC20945@sigill.intra.peff.net>
In-Reply-To
<7v1ukbys0n.fsf@alter.siamese.dyndns.org>
On Mon, Jul 16, 2012 at 08:40:24PM -0700, Junio C Hamano wrote:
Show 6 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > ... But whatever we call it, I think it is an
> > improvement.
> 
> I didn't say it makes things worse in any way, did I?

No, you did not. That was my attempt to end the paragraph on a positive and constructive note. What I meant was "I think you are wrong and it is a bugfix, but I do not care overly what we call it as long as we do it." :)

Do note that my "as long as we do it" is about the direction, not the patch. There are a few issues with the patch itself, and I just posted a review.

> I was reacting on the Subject: line because that will what I later
> have to work from when reading shortlog, summarizing changes, etc.

That is a fair point. From the release notes perspective, it probably is a feature (there is a documentation bug, but it happens to be fixed at the same time).

-Peff
Previous: Junio C HamanoNext: Jeff King
Message 7 of 15 in “rev-list: fix place holder %N (notes) in user format”
  1. rev-list: fix place holder %N (notes) in user formatJukka Lehtniemi, Mar 24, 2012
  2. Jeff KingMar 25, 2012
  3. Fix notes handling in rev-listJukka Lehtniemi, Jul 16, 2012
  4. Junio C HamanoJul 16, 2012
  5. Jeff KingJul 17, 2012
  6. Junio C HamanoJul 17, 2012
  7. Jeff KingJul 17, 2012
  8. Jeff KingJul 17, 2012
  9. Junio C HamanoJul 17, 2012
  10. Jukka LehtniemiJul 17, 2012
  11. Jeff KingJul 18, 2012
  12. Junio C HamanoJul 18, 2012
  13. Jeff KingJul 19, 2012
  14. Junio C HamanoJul 19, 2012
  15. Jeff KingJul 19, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.