From: karthik nayak Date: Mon, 12 Aug 2024 09:12:30 GMT Subject: Re: [PATCH v2 22/22] builtin/diff: free symmetric diff members Message-ID: In-Reply-To: <343ddcd17b3e13dc7b8ab89f9c9c427bb2ed101c.1723121979.git.ps@pks.im> Patrick Steinhardt writes: > We populate a `struct symdiff` in case the user has requested a > symmetric diff. Part of this is to populate a `skip` bitmap that > indicates whihc commits shall be ignored in the diff. But while this s/whihc/which > bitmap is dynamically allocated, we never free it. > > Fix this by introducing and calling a new `symdiff_release()` function > that does this for us. > [snip]