Re: [PATCH 1/3] cherry-pick: add support to copy notes
On Wed, May 29, 2013 at 3:09 AM, Thomas Rast <trast@inf.ethz.ch> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>> Feel free to implement that. I'm just interested in 'git cherry-pick' being
>> usable for 'git rebase' purposes.
>
> Which would have been obvious to all but the most casual readers, eh?
My motivations are irrelevant, the patch is good as it is.
Show 6 quoted lines
> We've been over this already:
>
> The body should provide a meaningful commit message, which:
>
> . explains the problem the change tries to solve, iow, what is wrong
> with the current code without the change.
Obvious; there is no support to copy notes.
> . justifies the way the change solves the problem, iow, why the
> result with the change is better.
Obvious: because it now actually copies the notes.
> . alternate solutions considered but discarded, if any.
There are no alternate solutions.
--
Felipe Contreras
Felipe Contreras <felipe.contreras@gmail.com>