git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] cherry-pick: add support to copy notes

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
May 29, 2013, 12:09 UTC
Message-ID
<CALkWK0k5+2nebRLZfWFpxyPmptV_Qo3sKwgpbpvN-bK6_S6W3w@mail.gmail.com>
In-Reply-To
<87y5ayqivi.fsf@linux-k42r.v.cablecom.net>
Thomas Rast wrote:
> So until this changes, my $0.02 is a blanket NAK and a refusal to spend
> my time reviewing.

Then don't review the damn thing. With Felipe, I have the following rule of thumb: make some concrete suggestions and forget about follow-ups. He's not going to accept any general guidelines, unless you're quoting Documentation/SubmittingPatches (and even then, it's subject to interpretation); so provide a commit message and hope that either he or Junio will use it. There is no guarantee that he will take any of your suggestions, no matter how sensible you think they might be. However, he is a productive programmer, and submits fixes to real issues. He's stubborn, and we can't do much to change that: just learn to work with him. I'm disappointed that I have to point this out: haven't you learnt anything from previous discussions with him?

Felipe, I suggest you put this in your commit message:
   This patch implements --copy-notes for 'git cherry-pick' so it can
copy notes in the same way that 'git rebase' does.
That is, if it's not too much trouble.

Stop this back-and-fourth nonsense, both of you. It's degrading the community, and hitting everyone's inboxes with garbage.

Previous: Felipe ContrerasNext: Felipe Contreras
Message 12 of 18 in “cherry-pick: improvments”
  1. 0/3 cherry-pick: improvmentsFelipe Contreras, May 28, 2013
  2. 1/3 cherry-pick: add support to copy notesFelipe Contreras, May 28, 2013
  3. Junio C HamanoMay 28, 2013
  4. Thomas RastMay 28, 2013
  5. Felipe ContrerasMay 29, 2013
  6. Thomas RastMay 29, 2013
  7. Felipe ContrerasMay 29, 2013
  8. Thomas RastMay 29, 2013
  9. Felipe ContrerasMay 29, 2013
  10. Thomas RastMay 29, 2013
  11. Felipe ContrerasMay 29, 2013
  12. Ramkumar RamachandraMay 29, 2013
  13. Felipe ContrerasMay 29, 2013
  14. Ramkumar RamachandraMay 29, 2013
  15. Felipe ContrerasMay 29, 2013
  16. Felipe ContrerasMay 29, 2013
  17. 2/3 revert/cherry-pick: add --quiet optionFelipe Contreras, May 28, 2013
  18. 3/3 revert/cherry-pick: add --skip optionFelipe Contreras, May 28, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.