git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] cherry-pick: add support to copy notes

From
Thomas Rast <trast@inf.ethz.ch>
Date
May 29, 2013, 11:34 UTC
Message-ID
<874ndmqate.fsf@linux-k42r.v.cablecom.net>
In-Reply-To
<CAMP44s2aAvzeTtHb=rVP1TrCMcQjyqN6O7n1DYZLx0uJrm1j+w@mail.gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 19 quoted lines
> On Wed, May 29, 2013 at 3:40 AM, Thomas Rast <trast@inf.ethz.ch> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> On Wed, May 29, 2013 at 3:09 AM, Thomas Rast <trast@inf.ethz.ch> wrote:
>>>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>>
>>>>> Feel free to implement that. I'm just interested in 'git cherry-pick' being
>>>>> usable for 'git rebase' purposes.
>>>>
>>>> Which would have been obvious to all but the most casual readers, eh?
>>>
>>> My motivations are irrelevant, the patch is good as it is.
>>
>> You fooled both Junio (AFAICT anyway) and me, who both reviewed the
>> patch under the assumption that it implements note copying *along the
>> lines of existing note copying*.  This proved to be a wrong, and
>> time-wasting, assumption.
>
> Whatever arbitrary rules you are talking about, they are not codified in tests.

Tests or code don't have a thing to do with it. This is about how you are presenting your changes to the rest of the git community. As evidenced above, said presentation is not clear enough to communicate your goals to at least two experienced git developers (if I may say so myself). How are we supposed to review a change if it is not even clear what goal it satisfies?

Again: I'll be happy to review your proposed changes if and when you
resend the series with commit messages.
-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Previous: Felipe ContrerasNext: Felipe Contreras
Message 10 of 18 in “cherry-pick: improvments”
  1. 0/3 cherry-pick: improvmentsFelipe Contreras, May 28, 2013
  2. 1/3 cherry-pick: add support to copy notesFelipe Contreras, May 28, 2013
  3. Junio C HamanoMay 28, 2013
  4. Thomas RastMay 28, 2013
  5. Felipe ContrerasMay 29, 2013
  6. Thomas RastMay 29, 2013
  7. Felipe ContrerasMay 29, 2013
  8. Thomas RastMay 29, 2013
  9. Felipe ContrerasMay 29, 2013
  10. Thomas RastMay 29, 2013
  11. Felipe ContrerasMay 29, 2013
  12. Ramkumar RamachandraMay 29, 2013
  13. Felipe ContrerasMay 29, 2013
  14. Ramkumar RamachandraMay 29, 2013
  15. Felipe ContrerasMay 29, 2013
  16. Felipe ContrerasMay 29, 2013
  17. 2/3 revert/cherry-pick: add --quiet optionFelipe Contreras, May 28, 2013
  18. 3/3 revert/cherry-pick: add --skip optionFelipe Contreras, May 28, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.