git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] cherry-pick: add support to copy notes

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
May 29, 2013, 13:48 UTC
Message-ID
<CALkWK0kK+Mbscsue0wwU5QDKXCrw5Q078MCdOVCoJnMZq7T6UA@mail.gmail.com>
In-Reply-To
<CAMP44s2tvUs813hrheWpWXR2G4kMJL4rscEtynaKYvw5a6HCHA@mail.gmail.com>
Felipe Contreras wrote:
> What you are really complaining about is that I don't agree with
> *every* single suggestion you make. And since you made them, they must
> be sensible, and single I don't agree with you, I must not be
> sensible, is that right?

Oh, I have no problems: I reviewed git-related, and it resulted in massive simplifications and improvements; those threads didn't run wild. I was mainly criticizing Thomas' review style (when it comes to reviewing your patches in particular), and was prodding him to "make concrete suggestions" in a one-email review, and leave it at that. What started out as a pointer to the guidelines:

Thomas Rast wrote:
> We've been over this already:
>
>   The body should provide a meaningful commit message, which:
has resulted in this thread running wild.
> There's nothing wrong with me choosing how best to spend my time. Really.

Ofcourse you are. You have arguably spent it very productively solving a lot of user issues (especially remote-bzr).

Personally, I try to do the minimum amount of boring work required to make sure that a good series gets in. Sometimes this is a little high (for a recent example, see my pickaxe-doc series). The result being that I just won't work on documentation in the future because doing iterations is so piss boring: the git community needs to recognize this problem and make amends.

Previous: Felipe ContrerasNext: Felipe Contreras
Message 14 of 18 in “cherry-pick: improvments”
  1. 0/3 cherry-pick: improvmentsFelipe Contreras, May 28, 2013
  2. 1/3 cherry-pick: add support to copy notesFelipe Contreras, May 28, 2013
  3. Junio C HamanoMay 28, 2013
  4. Thomas RastMay 28, 2013
  5. Felipe ContrerasMay 29, 2013
  6. Thomas RastMay 29, 2013
  7. Felipe ContrerasMay 29, 2013
  8. Thomas RastMay 29, 2013
  9. Felipe ContrerasMay 29, 2013
  10. Thomas RastMay 29, 2013
  11. Felipe ContrerasMay 29, 2013
  12. Ramkumar RamachandraMay 29, 2013
  13. Felipe ContrerasMay 29, 2013
  14. Ramkumar RamachandraMay 29, 2013
  15. Felipe ContrerasMay 29, 2013
  16. Felipe ContrerasMay 29, 2013
  17. 2/3 revert/cherry-pick: add --quiet optionFelipe Contreras, May 28, 2013
  18. 3/3 revert/cherry-pick: add --skip optionFelipe Contreras, May 28, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.