Re: [PATCH 1/3] cherry-pick: add support to copy notes

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 29, 2013, 11:56 UTC
Message-ID: <CAMP44s2de-kNnxQvLNE5QrDFYMX=Omyu61+J=Dbxp0of3iYGxg@mail.gmail.com>
In-Reply-To: <874ndmqate.fsf@linux-k42r.v.cablecom.net>

On Wed, May 29, 2013 at 6:34 AM, Thomas Rast <trast@inf.ethz.ch> wrote:

Show 28 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Wed, May 29, 2013 at 3:40 AM, Thomas Rast <trast@inf.ethz.ch> wrote:
>>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>>
>>>> On Wed, May 29, 2013 at 3:09 AM, Thomas Rast <trast@inf.ethz.ch> wrote:
>>>>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>>>
>>>>>> Feel free to implement that. I'm just interested in 'git cherry-pick' being
>>>>>> usable for 'git rebase' purposes.
>>>>>
>>>>> Which would have been obvious to all but the most casual readers, eh?
>>>>
>>>> My motivations are irrelevant, the patch is good as it is.
>>>
>>> You fooled both Junio (AFAICT anyway) and me, who both reviewed the
>>> patch under the assumption that it implements note copying *along the
>>> lines of existing note copying*.  This proved to be a wrong, and
>>> time-wasting, assumption.
>>
>> Whatever arbitrary rules you are talking about, they are not codified in tests.
>
> Tests or code don't have a thing to do with it.  This is about how you
> are presenting your changes to the rest of the git community.  As
> evidenced above, said presentation is not clear enough to communicate
> your goals to at least two experienced git developers (if I may say so
> myself).  How are we supposed to review a change if it is not even clear
> what goal it satisfies?

My goals are irrelevant. This patch is good.

It implements a missing feature, if you don't like how it is implemented it:

a) Implement the code in the note framework that does it properly so other people can just call that.

b) Implement the tests for other commands that check that the behavior you talk about does happen indeed.

c) Implement it yourself

This has nothing to do with the way I presented the patch. I presented the patch as I thought it was; implementing the note copying as it was intended. Now you came along and say I wasted your time because I didn't say I implemented it wrongly, and you assume bad faith and what not.

This wouldn't have happened because you didn't do a) or b). I realized that by replacing 'am' with 'cherry-pick' in 'git rebase' the notes were not copied, according to the testing framework, so I implemented that, and the tests pass. Now you come along and say it should implemented some note.rewrite.command stuff, but the tests didn't check for that, so how was I supposed to know?

And then you have the audacity to claim that *I*, the one who just wrote a bunch of code to implement a missing feature, is wasting *your* time, you, the one who is simply replying to an email and shooting from the hip.

> Again: I'll be happy to review your proposed changes if and when you
> resend the series with commit messages.

I won't, I'll keep working on my actual objective.

Plus, this patch does have a commit message, and the commit message says *EXACTLY* what the patch is doing: add support to copy notes.

If *you* are interested in certain behavior, why don't you lift a finger and do something to make sure that such behavior is easy to implement and the test framework actually checks for that?

-- 
Felipe Contreras