Re: [PATCH 1/3] cherry-pick: add support to copy notes

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 29, 2013, 11:18 UTC
Message-ID: <CAMP44s2aAvzeTtHb=rVP1TrCMcQjyqN6O7n1DYZLx0uJrm1j+w@mail.gmail.com>
In-Reply-To: <87y5ayqivi.fsf@linux-k42r.v.cablecom.net>

On Wed, May 29, 2013 at 3:40 AM, Thomas Rast <trast@inf.ethz.ch> wrote:

Show 16 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Wed, May 29, 2013 at 3:09 AM, Thomas Rast <trast@inf.ethz.ch> wrote:
>>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>>> Feel free to implement that. I'm just interested in 'git cherry-pick' being
>>>> usable for 'git rebase' purposes.
>>>
>>> Which would have been obvious to all but the most casual readers, eh?
>>
>> My motivations are irrelevant, the patch is good as it is.
>
> You fooled both Junio (AFAICT anyway) and me, who both reviewed the
> patch under the assumption that it implements note copying *along the
> lines of existing note copying*.  This proved to be a wrong, and
> time-wasting, assumption.

Whatever arbitrary rules you are talking about, they are not codified in tests.

If you care so much about "*the lines of existing note copying*", why don't you implement tests that check for those? This not only would prevent that some shmuck who is not well versed in the tradition of "the lines of existing note copying" from breaking that tradition, which is precisely what tests are for.

If this was done, we wouldn't be "time-wasting" here.

This patch makes 'git cherry-pick' pass all the tests that 'git rebase' passes. Period.

Even if it was against "the lines of existing note copying", it's much better than the current situation, which is to do ABSOLUTELY NOTHING.

If you were a productive person, you would take this patch and implement the code that makes it align to "the lines of existing note copying" that you care so much about, which should be easy, if the note framework was properly implement, but you won't.

Why isn't this implemented?

void copy_notes_for_rewrite(const char *rewrite_cmd, struct rewritten *list);

If there was such a thing, other clients wouldn't need to implement their own methods of copying notes.

But you didn't implement that, did you?

You are punishing me because the notes framework is lacking, and because the testing framework is missing what you think is the proper behavior.

Strike that, you are punishing the users.

-- 
Felipe Contreras