git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/7] remote-hg: don't decode UTF-8 paths into Unicode objects

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Nov 11, 2013, 19:10 UTC
Message-ID
<CAMP44s2BcmuLeLOgA592g7F117LU--uhWVFNq1W6gn+uvURmvA@mail.gmail.com>
In-Reply-To
<52812258.1060109@bbn.com>
On Mon, Nov 11, 2013 at 12:30 PM, Richard Hansen <rhansen@bbn.com> wrote:
Show 13 quoted lines
> On 2013-11-11 06:04, Felipe Contreras wrote:
>> Richard Hansen wrote:
>>> The internal mercurial API expects ordinary 8-bit string objects, not
>>> Unicode string objects.  With this change, the test-hg.sh unit tests
>>> pass again.
>>
>> This makes sense to me, but the tests are already passing for me. How are they
>> failing for you?
>
> $ hg --version | head -n 1
> Mercurial Distributed SCM (version 2.2.2)
> $ cd ~/git/t
> $ ../contrib/remote-helpers/test-hg.sh --verbose --immediate
Ah, I see they are failing now (v 2.8). I don't know what I was testing.
FWIW my tree doesn't have this problem [1].
> I can put the above in the commit message if people would like it there.

Personally I think it's overkill. You mentioned the tests failed, that's enough explanation. I just wanted to see if that was actually the case.

[1] https://travis-ci.org/felipec/git-travis
-- 
Felipe Contreras
Previous: Richard HansenNext: Richard Hansen
Message 5 of 56 in “remote-hg, remote-bzr fixes”
  1. 0/7 remote-hg, remote-bzr fixesRichard Hansen, Nov 11, 2013
  2. 1/7 remote-hg: don't decode UTF-8 paths into Unicode objectsRichard Hansen, Nov 11, 2013
  3. Felipe ContrerasNov 11, 2013
  4. Richard HansenNov 11, 2013
  5. Felipe ContrerasNov 11, 2013
  6. 2/7 test-bzr.sh, test-hg.sh: allow running from any dirRichard Hansen, Nov 11, 2013
  7. Felipe ContrerasNov 11, 2013
  8. Junio C HamanoNov 11, 2013
  9. Felipe ContrerasNov 11, 2013
  10. 3/7 test-bzr.sh, test-hg.sh: prepare for change to push.default=simpleRichard Hansen, Nov 11, 2013
  11. Felipe ContrerasNov 11, 2013
  12. Richard HansenNov 11, 2013
  13. Felipe ContrerasNov 11, 2013
  14. Richard HansenNov 11, 2013
  15. Felipe ContrerasNov 11, 2013
  16. 4/7 test-hg.sh: eliminate 'local' bashismRichard Hansen, Nov 11, 2013
  17. Felipe ContrerasNov 11, 2013
  18. 5/7 test-hg.sh: avoid obsolete 'test' syntaxRichard Hansen, Nov 11, 2013
  19. Felipe ContrerasNov 11, 2013
  20. Richard HansenNov 12, 2013
  21. Felipe ContrerasNov 12, 2013
  22. 6/7 test-hg.sh: help user correlate verbose output with email testRichard Hansen, Nov 11, 2013
  23. Felipe ContrerasNov 11, 2013
  24. Richard HansenNov 11, 2013
  25. Felipe ContrerasNov 11, 2013
  26. Richard HansenNov 11, 2013
  27. 7/7 remote-bzr, remote-hg: fix email address regular expressionRichard Hansen, Nov 11, 2013
  28. Felipe ContrerasNov 11, 2013
  29. Junio C HamanoNov 11, 2013
  30. 0/9 remote-hg, remote-bzr fixesRichard Hansen, Nov 12, 2013
  31. 1/9 remote-hg: don't decode UTF-8 paths into Unicode objectsRichard Hansen, Nov 12, 2013
  32. 2/9 test-lib.sh: convert $TEST_DIRECTORY to an absolute pathRichard Hansen, Nov 12, 2013
  33. Richard HansenNov 12, 2013
  34. Junio C HamanoNov 12, 2013
  35. Felipe ContrerasNov 12, 2013
  36. 3/9 test-bzr.sh, test-hg.sh: allow running from any dirRichard Hansen, Nov 12, 2013
  37. 4/9 test-bzr.sh, test-hg.sh: prepare for change to push.default=simpleRichard Hansen, Nov 12, 2013
  38. 5/9 test-hg.sh: eliminate 'local' bashismRichard Hansen, Nov 12, 2013
  39. 6/9 test-hg.sh: avoid obsolete 'test' syntaxRichard Hansen, Nov 12, 2013
  40. 7/9 test-hg.sh: fix duplicate content strings in author testsRichard Hansen, Nov 12, 2013
  41. 8/9 test-hg.sh: help user correlate verbose output with email testRichard Hansen, Nov 12, 2013
  42. 9/9 remote-bzr, remote-hg: fix email address regular expressionRichard Hansen, Nov 12, 2013
  43. Junio C HamanoNov 12, 2013
  44. Felipe ContrerasNov 12, 2013
  45. 0/9 remote-hg, remote-bzr fixesRichard Hansen, Nov 18, 2013
  46. 1/9 remote-hg: don't decode UTF-8 paths into Unicode objectsRichard Hansen, Nov 18, 2013
  47. 2/9 test-lib.sh: convert $TEST_DIRECTORY to an absolute pathRichard Hansen, Nov 18, 2013
  48. 3/9 test-bzr.sh, test-hg.sh: allow running from any dirRichard Hansen, Nov 18, 2013
  49. 4/9 test-bzr.sh, test-hg.sh: prepare for change to push.default=simpleRichard Hansen, Nov 18, 2013
  50. 5/9 test-hg.sh: eliminate 'local' bashismRichard Hansen, Nov 18, 2013
  51. 6/9 test-hg.sh: avoid obsolete 'test' syntaxRichard Hansen, Nov 18, 2013
  52. 7/9 test-hg.sh: fix duplicate content strings in author testsRichard Hansen, Nov 18, 2013
  53. 8/9 test-hg.sh: help user correlate verbose output with email testRichard Hansen, Nov 18, 2013
  54. 9/9 remote-bzr, remote-hg: fix email address regular expressionRichard Hansen, Nov 18, 2013
  55. Junio C HamanoNov 18, 2013
  56. Junio C HamanoNov 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.