Re: [PATCH v2 2/9] test-lib.sh: convert $TEST_DIRECTORY to an absolute path

From: Richard Hansen <rhansen@bbn.com>
Date: Nov 12, 2013, 06:05 UTC
Message-ID: <5281C522.7050403@bbn.com>
In-Reply-To: <1384235688-9655-3-git-send-email-rhansen@bbn.com>

On 2013-11-12 00:54, Richard Hansen wrote:

Show 5 quoted lines

> If $TEST_DIRECTORY is specified in the environment, convert the value
> to an absolute path to ensure that it remains valid even when 'cd' is
> used.
> 
> Signed-off-by: Richard Hansen <rhansen@bbn.com>

Actually, credit for this and the next patch should go to Felipe. How should I note that?

Thanks, Richard

Show 19 quoted lines

> ---
>  t/test-lib.sh | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index b25249e..af172d9 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -26,6 +26,10 @@ then
>  	# outside of t/, e.g. for running tests on the test library
>  	# itself.
>  	TEST_DIRECTORY=$(pwd)
> +else
> +	# ensure that TEST_DIRECTORY is an absolute path so that it
> +	# works even if the current working directory is changed
> +	TEST_DIRECTORY=$(cd "$TEST_DIRECTORY" && pwd) || exit 1
>  fi
>  if test -z "$TEST_OUTPUT_DIRECTORY"
>  then