[PATCH 5/7] test-hg.sh: avoid obsolete 'test' syntax
- From
- Richard Hansen <rhansen@bbn.com>
- Date
- Nov 11, 2013, 04:05 UTC
- Message-ID
- <1384142712-2936-6-git-send-email-rhansen@bbn.com>
- In-Reply-To
- <1384142712-2936-1-git-send-email-rhansen@bbn.com>
The POSIX spec says that the '-a', '-o', and parentheses operands to the 'test' utility are obsolete extensions due to the potential for ambiguity. Replace '-o' with '|| test' to avoid unspecified behavior.
Signed-off-by: Richard Hansen <rhansen@bbn.com> --- contrib/remote-helpers/test-hg.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh index 558a656..84c67ff 100755 --- a/contrib/remote-helpers/test-hg.sh +++ b/contrib/remote-helpers/test-hg.sh @@ -83,7 +83,7 @@ check_push () { test $ref_ret -ne 0 && echo "match for '$branch' failed" && break done - if test $expected_ret -ne $ret -o $ref_ret -ne 0 + if test $expected_ret -ne $ret || test $ref_ret -ne 0 then return 1 fi
-- 1.8.5.rc1.207.gc17dd22