Re: [PATCH 3/7] test-bzr.sh, test-hg.sh: prepare for change to push.default=simple

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Nov 11, 2013, 21:19 UTC
Message-ID: <CAMP44s1fc2UMZE4Y5sdTuKuU_p1sLo02jiBppabywSjxFfR6Eg@mail.gmail.com>
In-Reply-To: <5281491A.4050806@bbn.com>

On Mon, Nov 11, 2013 at 3:16 PM, Richard Hansen <rhansen@bbn.com> wrote:

Show 15 quoted lines

> On 2013-11-11 14:31, Felipe Contreras wrote:
>> On Sun, Nov 10, 2013 at 10:05 PM, Richard Hansen <rhansen@bbn.com> wrote:
>>
>>> @@ -379,7 +382,7 @@ test_expect_success 'export utf-8 authors' '
>>>         git add content &&
>>>         git commit -m one &&
>>>         git remote add bzr "bzr::../bzrrepo" &&
>>> -       git push bzr
>>> +       git push -u bzr master
>>>         ) &&
>>
>> Actually, why -u? Isn't 'git push bzr master' enough?
>
> It's defensive in case that test is ever updated to do more pushing.  I
> can leave it out in the reroll.

Please do. If there's any need for that we can add it later, but even then I would prefer that the push explicit again, like this one. And suspect we will not need to update this in that direction.

-- 
Felipe Contreras