Re: [PATCH 2/7] test-bzr.sh, test-hg.sh: allow running from any dir

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 11, 2013, 18:31 UTC
Message-ID: <xmqqsiv2lrig.fsf@gitster.dls.corp.google.com>
In-Reply-To: <5280c108749d8_6841541e787e@nysa.notmuch>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 24 quoted lines

> Richard Hansen wrote:
>> cd to the t/ subdirectory so that the user doesn't already have to be
>> in the test directory to run these test scripts.
>> 
>> Signed-off-by: Richard Hansen <rhansen@bbn.com>
>> ---
>>  contrib/remote-helpers/test-bzr.sh | 1 +
>>  contrib/remote-helpers/test-hg.sh  | 1 +
>>  2 files changed, 2 insertions(+)
>> 
>> diff --git a/contrib/remote-helpers/test-bzr.sh b/contrib/remote-helpers/test-bzr.sh
>> index 5c50251..094062c 100755
>> --- a/contrib/remote-helpers/test-bzr.sh
>> +++ b/contrib/remote-helpers/test-bzr.sh
>> @@ -5,6 +5,7 @@
>>  
>>  test_description='Test remote-bzr'
>>  
>> +cd "${0%/*}"/../../t || exit 1
>
> I think this should do the trick:
>
>   test -z "$TEST_DIRECTORY" && TEST_DIRECTORY="$(realpath ${0%/*}/../../t)"
>   . "$TEST_DIRECTORY"/test-lib.sh

Can we do that without using realpath(1)? I do not think we use it anywhere in the main part of the project.