From: Felipe Contreras Date: Mon, 11 Nov 2013 19:10:50 GMT Subject: Re: [PATCH 1/7] remote-hg: don't decode UTF-8 paths into Unicode objects Message-ID: In-Reply-To: <52812258.1060109@bbn.com> On Mon, Nov 11, 2013 at 12:30 PM, Richard Hansen wrote: > On 2013-11-11 06:04, Felipe Contreras wrote: >> Richard Hansen wrote: >>> The internal mercurial API expects ordinary 8-bit string objects, not >>> Unicode string objects. With this change, the test-hg.sh unit tests >>> pass again. >> >> This makes sense to me, but the tests are already passing for me. How are they >> failing for you? > > $ hg --version | head -n 1 > Mercurial Distributed SCM (version 2.2.2) > $ cd ~/git/t > $ ../contrib/remote-helpers/test-hg.sh --verbose --immediate Ah, I see they are failing now (v 2.8). I don't know what I was testing. FWIW my tree doesn't have this problem [1]. > I can put the above in the commit message if people would like it there. Personally I think it's overkill. You mentioned the tests failed, that's enough explanation. I just wanted to see if that was actually the case. [1] https://travis-ci.org/felipec/git-travis -- Felipe Contreras