Re: [PATCH 6/7] test-hg.sh: help user correlate verbose output with email test
- From
- Richard Hansen <rhansen@bbn.com>
- Date
- Nov 11, 2013, 19:19 UTC
- Message-ID
- <52812DD2.9030506@bbn.com>
- In-Reply-To
- <5280c2c3e066c_6841541e7824@nysa.notmuch>
On 2013-11-11 06:42, Felipe Contreras wrote:
Show 19 quoted lines
> Richard Hansen wrote: >> It's hard to tell which author conversion test failed when the email >> addresses look similar. >> >> Signed-off-by: Richard Hansen <rhansen@bbn.com> >> --- >> contrib/remote-helpers/test-hg.sh | 20 ++++++++++---------- >> 1 file changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh >> index 84c67ff..5eda265 100755 >> --- a/contrib/remote-helpers/test-hg.sh >> +++ b/contrib/remote-helpers/test-hg.sh >> @@ -209,16 +209,16 @@ test_expect_success 'authors' ' >> >> >../expected && >> author_test alpha "" "H G Wells <wells@example.com>" && >> - author_test beta "test" "test <unknown>" && >> - author_test beta "test <test@example.com> (comment)" "test <test@example.com>" &&
Notice the two betas here in the original code.
Show 12 quoted lines
>> - author_test gamma "<test@example.com>" "Unknown <test@example.com>" && >> - author_test delta "name<test@example.com>" "name <test@example.com>" && >> - author_test epsilon "name <test@example.com" "name <test@example.com>" && >> - author_test zeta " test " "test <unknown>" && >> - author_test eta "test < test@example.com >" "test <test@example.com>" && >> - author_test theta "test >test@example.com>" "test <test@example.com>" && >> - author_test iota "test < test <at> example <dot> com>" "test <unknown>" && >> - author_test kappa "test@example.com" "Unknown <test@example.com>" >> + author_test beta "beta" "beta <unknown>" && >> + author_test beta "beta <test@example.com> (comment)" "beta <test@example.com>" && > > Two betas?
See above. I can change them to beta1 and beta2, or if you'd prefer I can change them to beta and gamma and increment the subsequent entries.
Thanks, Richard
Show 13 quoted lines
> >> + author_test gamma "<gamma@example.com>" "Unknown <gamma@example.com>" && >> + author_test delta "delta<test@example.com>" "delta <test@example.com>" && >> + author_test epsilon "epsilon <test@example.com" "epsilon <test@example.com>" && >> + author_test zeta " zeta " "zeta <unknown>" && >> + author_test eta "eta < test@example.com >" "eta <test@example.com>" && >> + author_test theta "theta >test@example.com>" "theta <test@example.com>" && >> + author_test iota "iota < test <at> example <dot> com>" "iota <unknown>" && >> + author_test kappa "kappa@example.com" "Unknown <kappa@example.com>" >> ) && >> >> git clone "hg::hgrepo" gitrepo && >