Re: [PATCH v3 15/23] cat-file: move skip_object_info into ref-filter

From: Оля Тележная <olyatelezhnaya@gmail.com>
Date: Feb 15, 2018, 10:27 UTC
Message-ID: <CAL21BmmvOHFve7FRfnRKuzsEm+Hkwo5AZUmqWrM-tmcbcLTSFQ@mail.gmail.com>
In-Reply-To: <20180215055158.GM18780@sigill.intra.peff.net>

2018-02-15 8:51 GMT+03:00 Jeff King <peff@peff.net>:

Show 13 quoted lines

> On Mon, Feb 12, 2018 at 08:08:54AM +0000, Olga Telezhnaya wrote:
>
>> Move logic related to skip_object_info into ref-filter,
>> so that cat-file does not use that field at all.
>
> I think this is going the wrong way. ref-filter should always do as
> little work as possible to fulfill the request. So it should skip the
> object_info call whenever it can. And then any callers who want to make
> sure that the object exists can do so (as long as the formatting code
> tells them whether it looked up the object or not).
>
> And then ref-filter doesn't have to know about this skip_object_info
> flag at all.

Your message looks contradictory to me. I agree that ref-filter should do as least as it's possible, and that is the main reason why I put this code there. Moreover, I think that it's a good idea to implement that variable not only for cat-file, but for all ref-filter callers. And I think that it's a task of ref-filter to check whether the object exists or not (or - whether the ref is valid or not). But I am not sure that I need to solve that moment in current patch. It sounds like another separate task.

>
> -Peff