Re: [PATCH v3 15/23] cat-file: move skip_object_info into ref-filter

From: Jeff King <peff@peff.net>
Date: Feb 15, 2018, 05:51 UTC
Message-ID: <20180215055158.GM18780@sigill.intra.peff.net>
In-Reply-To: <01020161890f435c-80fa0ef3-afaf-45b7-84a7-28e2bb66f320-000000@eu-west-1.amazonses.com>

On Mon, Feb 12, 2018 at 08:08:54AM +0000, Olga Telezhnaya wrote:

> Move logic related to skip_object_info into ref-filter,
> so that cat-file does not use that field at all.

I think this is going the wrong way. ref-filter should always do as little work as possible to fulfill the request. So it should skip the object_info call whenever it can. And then any callers who want to make sure that the object exists can do so (as long as the formatting code tells them whether it looked up the object or not).

And then ref-filter doesn't have to know about this skip_object_info flag at all.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.