Re: [PATCH v3 13/23] ref-filter: get rid of mark_atom_in_object_info()

From: Jeff King <peff@peff.net>
Date: Feb 15, 2018, 05:45 UTC
Message-ID: <20180215054542.GK18780@sigill.intra.peff.net>
In-Reply-To: <01020161890f4353-44cc5f60-0e42-492a-9d7f-0f6f1c7b3501-000000@eu-west-1.amazonses.com>

On Mon, Feb 12, 2018 at 08:08:54AM +0000, Olga Telezhnaya wrote:

> Remove mark_atom_in_object_info() and create same logic
> in terms of ref-filter style.

This one is definitely a step in the right direction. In fact, this is what I would have expected to see in the beginning. It seems like this first half of the series really would benefit from being squashed into a few commits. I.e., I'd have expected to see the whole series looking something like:

  - preparatory cleanup of ref-filter

  - teach ref-filter any new atoms (or atom options) that cat-file knows
    about but it doesn't

  - convert cat-file to use ref-filter

Most of what I've seen so far is basically that second step, but strung out along a bunch of commits. Can we compact it into a few commits that all make clear forward progress (by using "rebase -i" with "squash")?

-Peff